Skip to content

grpc/credentials/client: Make ChannelCredentials object safe#2703

Merged
arjan-bal merged 4 commits into
grpc:masterfrom
arjan-bal:object-safe-channel-creds
Jun 26, 2026
Merged

grpc/credentials/client: Make ChannelCredentials object safe#2703
arjan-bal merged 4 commits into
grpc:masterfrom
arjan-bal:object-safe-channel-creds

Conversation

@arjan-bal

@arjan-bal arjan-bal commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This update makes the ChannelCredentials trait object-safe and removes the DynChannelCredentials trait, which simplifies the channel constructor by dropping its generic parameters. It also renames ClientConnectionSecurityInfo to ChannelSecurityInfo.

@arjan-bal arjan-bal changed the title grpc/credentials/client: Make ChanneCredentials object safe grpc/credentials/client: Make ChannelCredentials object safe Jun 25, 2026
@arjan-bal arjan-bal requested review from dfawley and ejona86 June 25, 2026 17:54
@arjan-bal

Copy link
Copy Markdown
Contributor Author

FYI @nathanielford

@ejona86

ejona86 commented Jun 25, 2026

Copy link
Copy Markdown
Member

FWIW, the BoxEndpoint is more significant in this change than boxing the security context, as it is called significantly more often.

@arjan-bal arjan-bal assigned arjan-bal and unassigned ejona86 and dfawley Jun 26, 2026
@arjan-bal arjan-bal merged commit 0d2733d into grpc:master Jun 26, 2026
26 checks passed
@arjan-bal arjan-bal deleted the object-safe-channel-creds branch June 26, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants