chore(CI): Cache well-known-type protos with protoc binary#2683
chore(CI): Cache well-known-type protos with protoc binary#2683arjan-bal wants to merge 1 commit into
Conversation
|
Ah, so you were looking at this as well. I just sent out #2685 I think with my change it'd be okay to not include .github/workflows/CI.yml in the cache key, since there is so little logic in CI.yml with my change. I didn't notice/remove |
I had asked Doug to remove it in an earlier PR, but tonic's prost codegen relied on well-known type protos that were missing in the compiled protoc. Now that we're including those, we don't need the install action. |
|
Closing in favour of #2685. |
Background: In #2665, the well-known-type protos were included in the output of the
protoc-gen-rust-grpccrate, but CI only cachedprotocandprotoc-gen-rust-grpc.Changes in this PR:
protocinstallation via thetaiki-e/install-action@protocaction, sinceprost-buildnow works with the cached binary.protocplugin is rebuilt whenever the workflow file changes, even if the source code remains untouched.