Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address protobuf linter warnings. #134

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Address protobuf linter warnings. #134

merged 1 commit into from
Aug 28, 2023

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Aug 28, 2023

  1. Default value should not be a value that is in use.
  2. Make enum nested so enum values are not global.

@eugeneo
Address protobuf linter warnings.
28db1ab 
1. Default value should not be a value that is in use.
2. Make enum nested so enum values are not global.
sanjaypujare
sanjaypujare approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugeneo eugeneo merged commit 374b488 into grpc:master Aug 28, 2023
1 check passed
@eugeneo eugeneo deleted the tasks/messages-enum-linter branch August 28, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@sanjaypujare sanjaypujare sanjaypujare approved these changes

Assignees

@sanjaypujare sanjaypujare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugeneo @ejona86 @sanjaypujare