feat(proto-loader-gen-types): add options for specifying file extensions #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
requested changes
Mar 3, 2025
|
@murgatroid99 |
murgatroid99
reviewed
Mar 4, 2025
murgatroid99
approved these changes
Mar 17, 2025
|
Nice to see this has landed, however it seems like a new version of |
|
This is now out in version 0.7.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following two options to
proto-loader-gen-types:targetFileExtension: File extension for generated files. Defaults to.tsimportFileExtension: File extension for import specifiers in generated code. Defaults to none (omitted)The default behavior of
proto-loader-gen-typesis kept unchanged to avoid any possible breaking on existing usage, and the output is only modified when options are provided as needed.Closes #2907