grpc-js: Handle race between bindAsync and (try|force)Shutdown #2590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests shared in #2581 show that if
bindAsync
is called, and thentryShutdown
orforceShutdown
is called before thebindAsync
operation completes, the result is that the port stays bound forever, holding the process open. This fixes the error by adding ashutdown
flag that is set bytryShutdown
andforceShutdown
, and ensuring thatbindAsync
does not leave ports bound if that flag is set. Specifically, it throws an error ifbindAsync
is called after shutdown, and adds checks after getting the resolver result and in thelisten
callback to not continue binding ports and/or close any bound ports.