Improve performance of batch operation serializer #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this change against the v1.10.x branch and either update this PR or send a new one? |
|
@murgatroid99 The code this is based on is not in v1.10.x, #59 was merged to master after 1.10.x was cut. |
|
You're right. Never mind. |
murgatroid99
approved these changes
Mar 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #59, addressing the performance penalties of the code I wrote to enforce a certain order in batch operations, as discussed here: #59 (comment)
This replaces the worst-performing lodash and standard library calls. In micro-benchmarks, _startBatchIfReady runs in about half the time after these changes are applied.