fix(grpc-js): Add support for typed add service #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem with the previous change was that it did not properly handle service definition objects that were typed as simply interface ServiceDefinition {
[key: string]: MethodDefinition
}along with implementation objects with types that specified the individual member names. I'm not sure if this change addresses that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds improved support for typed
addService.Previous attempt (#1556) broke due to https://source.cloud.google.com/results/invocations/a9b120c7-c487-453a-82c8-0d29b91b73ce/targets/grpc%2Fnode%2Fpull_request%2Flinux/log.