grpc-js: Don't initiate a read after receiving a message #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasnoble
approved these changes
Jun 16, 2020
badsyntax
reviewed
Jun 17, 2020
| @@ -51,7 +51,7 @@ function echoMetadataGenerator(options, callback) { | |||
|
|
|||
| const credentials = grpc.credentials.createFromMetadataGenerator(echoMetadataGenerator); | |||
|
|
|||
| describe(`${anyGrpc.clientName} client -> ${anyGrpc.serverName} server`, function() { | |||
| describe.only(`${anyGrpc.clientName} client -> ${anyGrpc.serverName} server`, function() { | |||
There was a problem hiding this comment.
Is this only intentional?
There was a problem hiding this comment.
No it is not. I left that in there from when I was fixing the test. Thanks for catching it.
This was referenced Jun 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the
Readablestream class will aggressively call_readeven ifpushreturnstrue, so we don't also need to start another read after pushing. This fixes #1473, at least according to the test case provided in that issue.