Skip to content

grpc-js: tests: skip checking for IPv6 addresses from DNS servers #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2020
Merged

grpc-js: tests: skip checking for IPv6 addresses from DNS servers #1297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions packages/grpc-js/test/test-resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,9 @@ describe('Name Resolver', () => {
const resolver = resolverManager.createResolver(target, listener);
resolver.updateResolution();
});
it('Should resolve a DNS name to an IPv6 address', done => {
/* TODO(murgatroid99): re-enable this test, once we can get the IPv6 result
* consistently */
it.skip('Should resolve a DNS name to an IPv6 address', done => {
const target = 'loopback6.unittest.grpc.io';
const listener: resolverManager.ResolverListener = {
onSuccessfulResolution: (
Expand Down Expand Up @@ -255,14 +257,8 @@ describe('Name Resolver', () => {
addr.port === 443
)
);
assert(
addressList.some(
addr =>
isTcpSubchannelAddress(addr) &&
addr.host === '::1' &&
addr.port === 443
)
);
/* TODO(murgatroid99): check for IPv6 result, once we can get that
* consistently */
done();
},
onError: (error: StatusObject) => {
Expand Down