Closed
Description
Problem description
When using tryShutdown to gracefully shutdown a server, it doesn't let unary RPCs finish successfully.
Reproduction steps
- Create GRPC server with unary handler that takes some extended amount of time
- Set up a
process.onhandler forSIGTERM - Call Unary GRPC
- Before it completes send
SIGTERMto the server process. - Note that client never receives the correct response, just a cancelled call. Even though the server sends the correct data.
Environment
- OS name, version and architecture: OSX 10.15.7
- Node version 17.8.0
- Package name and version grpc-js@1.3.7
Additional context
The normal process for a Unary RPC (that I can deduce from debugging) is as follows:
Clientopens stream toServerClientsends request toServerServersends response toClientClientcloses stream.
When using the tryShutdown method the process is different.
Clientopens stream toServerClientsends request toServertryShutdownis calledServercallscloseon http2 sessionServersends response toClientClientsee's that stream has been cancelled, and errors.
The cancellation appears to be coming from the session destruction happening in tryShutdown. This makes sense for streaming GRPC calls, as they need to be cancelled, but a Unary GRPC should be able to finish its response without the call being cancelled.
Removing the session.close() from tryShutdown fixes the problem for Unary GRPCs, but obviously doesn't for Streaming GRPCs.