Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
servlet: Implement gRPC server as a Servlet #8596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
servlet: Implement gRPC server as a Servlet #8596
Changes from 127 commits
a0c92df
8719377
46d00ec
4fa6271
e793c7c
393fcf6
706a3c9
5e11674
1776917
bb3a720
4c7cd4f
af7f6a3
2fc04fc
6fb4fc2
8b78b6d
680872b
b3473df
3728866
58fce63
5b02064
d59f81e
5b7496e
e98e4f8
6aa26e4
c3dfaba
44ea5f3
ef5f879
47e3e95
c5fc2bd
63e8cb2
986a885
3fd4ca8
09967c1
7d8410f
a53114b
ae0085f
9a02c82
7977de6
811fcbe
ccbfd8d
5d017a3
0180d29
7bb191c
59d9754
1f4b0ca
ccc5cd6
7d90af8
aea3351
70ca920
83d405e
18d20d3
f4c0c87
b12370e
a39be4c
dea10c6
2154764
bf5c225
a0b5852
512a2d3
4bed353
907f432
75f9b82
cf3decb
00b8f76
35e0af2
0c5664c
8162d6e
8e25c4c
3bcd0af
034771f
da85cf8
f84a156
f7677f6
dc2ddcf
cc9eb3f
67eb249
c8eea3b
36c4e08
490abf2
0db2bdf
6440b3b
cc2297d
6197088
9acba27
44fc657
6764b77
7cce389
33639da
822701e
f1a2ff3
2a26e5e
a72bed1
a67519c
0741d02
c88e1ce
4a55684
d77973e
e632dde
c903d75
0bc4dcc
d73bad1
714e81b
1962a0e
022c66c
bfef2a2
bd3d791
533bd21
6f7e626
bc802ae
b1da336
93f1c6f
0e64316
38c0585
5cb764a
986ee81
95c350f
7a90a53
f8b9950
576d64e
50020b3
79dc180
6d58c9b
dda244d
5829381
7ae71dc
639084a
b13d505
5bbaea3
524bbe9
129628e
4c68cfb
f26201a
7929461
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to build out such an example/docs - since servlets are instantiated via their default constructor, it can be irritating expose the set of bindableservices that will be expected to be served (via a runtime Set), while also offering a configuration like this annotation that describes the urls to map to.
This might suggest offering a Filter in addition to a Servlet, which can check its set of bindings and only handle the call if it matches (checking the req.getRequestURI().substring(1) as ServletAdapter.doPost does, and comparing against its set), otherwise letting some later filter/servlet take over. It could also perform the content-type check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should have an example to use extension of
GrpcServlet
directly, maybe implementing the routeguide service, in addition to the existing example.As for Filter, that might be something we can add after this PR being merged, and have this PR only support the most basic servlet API. Same for the grpc-web support.