Revert "netty: add exporting SSL/TLS master key log feature (#7724)" #7792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9bc05fb.
ejona86
approved these changes
Jan 8, 2021
Member
|
Doh. May be a general new Netty issue, or it could be fallout from TLSv1.3 being enabled. |
voidzcy
added a commit
to voidzcy/grpc-java
that referenced
this pull request
Jan 9, 2021
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9bc05fb.
Tests are broken https://travis-ci.org/github/grpc/grpc-java/jobs/753603250. Might be related to recent Netty upgrade. Reverting it for now.
/cc @ericgribkoff @huangqiangxiong