bazel: update protobuf dependency #5212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes grpc-java compatible with recent Bazel releases by pulling in changes including: protocolbuffers/protobuf#4650 protocolbuffers/protobuf@c2f88de
Member
|
@drigz, sorry for the late reply. Go ahead and update all references of protobuf to the 3.6.1 release (like in the other PR you mentioned). It's safe since gRPC dropped support for Java 6 (#3961). In the past updating protobuf version has been a bit of a pain because of compiler warnings. If it becomes too painful for you just tell us and we will work on bumping the version. |
Contributor
Author
Member
|
@drigz, oh, you leave javanano in the past. Sorry for the confusion. We can take it from here. Let's leave this open until we make a replacement PR. |
Member
|
Closing in favor of #5320 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes grpc-java compatible with recent Bazel releases by pulling
in changes including:
protocolbuffers/protobuf#4650
protocolbuffers/protobuf@c2f88de
Is it OK to update the Bazel dependency separately, or should I update references, as in #3921?