Skip to content

fix: configure Undertow test entity size#12892

Open
Zhengcy05 wants to merge 1 commit into
grpc:masterfrom
Zhengcy05:fix/undertow-large-request-limit
Open

fix: configure Undertow test entity size#12892
Zhengcy05 wants to merge 1 commit into
grpc:masterfrom
Zhengcy05:fix/undertow-large-request-limit

Conversation

@Zhengcy05

Copy link
Copy Markdown

fixes #12859

Background

This PR updates the grpc-servlet Undertow tests to work with Undertow 2.2.39.Final and 2.3.21.Final.

Those releases changed Undertow's default MAX_ENTITY_SIZE to 2 MiB, which caused UndertowInteropTest.veryLargeRequest() to fail before the request reached the gRPC servlet.

Cause

UndertowInteropTest.veryLargeRequest() sends a 10 MiB unary request. The test server already configured gRPC's maxInboundMessageSize, but it did not configure Undertow's container-level entity size limit.

After the Undertow default changed, the container started rejecting the request and the client saw RST_STREAM ... CANCEL.

Changes

  • Set UndertowOptions.MAX_ENTITY_SIZE explicitly in UndertowInteropTest
  • Set UndertowOptions.MAX_ENTITY_SIZE explicitly in UndertowTransportTest to keep the transport test environment effectively unbounded
  • Upgrade Undertow test dependencies to 2.2.39.Final and 2.3.21.Final

Verification

  • ./gradlew -PskipAndroid=true -PskipCodegen=true :grpc-servlet:undertowTest --tests io.grpc.servlet.UndertowInteropTest
  • ./gradlew -PskipAndroid=true -PskipCodegen=true :grpc-servlet:undertowTest --tests io.grpc.servlet.UndertowTransportTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UndertowInteropTest.veryLargeRequest() starts failing with Undertow 2.2.39 and 2.3.21

1 participant