Skip to content

xds: Enable Xds Client Fallback by default #11817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

xds: Enable Xds Client Fallback by default #11817

merged 1 commit into from
Jan 10, 2025

Conversation

larry-safran
Copy link
Contributor

No description provided.

@larry-safran larry-safran requested a review from ejona86 January 10, 2025 22:08
danielzhaotongliu
danielzhaotongliu approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@danielzhaotongliu danielzhaotongliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Internally have been usingSystem.setProperty to enable xDS fallback. Now with this PR, this feature graduates from experimental and can remove the System.setProperty internally.

ejona86
ejona86 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to push and get this backported to 1.70, or are we just going to wait for 1.71?

@larry-safran larry-safran merged commit 176f3ee into grpc:master Jan 10, 2025
16 checks passed
@larry-safran larry-safran deleted the enableFallback branch January 10, 2025 23:25
@larry-safran
Copy link
Contributor Author

I believe the only driver has been Prod, so it can wait for 1.71.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@danielzhaotongliu danielzhaotongliu danielzhaotongliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larry-safran @ejona86 @danielzhaotongliu