Make Ring Hash LB a petiole policy#10610

Merged

larry-safran merged 26 commits intogrpc:masterfrom

larry-safran:ring_hash_dualstack

Nov 9, 2023

Commits on Nov 9, 2023

Checkpoint
larry-safran
committed
Complete fixing implementation and tests so that all tests pass as expected.
larry-safran
committed
Update picker logic per A61 that it no longer pays attention to the first 2 elements, but rather takes the first ring element not in TF and uses that.
larry-safran
committed
Fix style issues.
larry-safran
committed
Cleanup after rebasing.
larry-safran
committed
Go back to caching the connectivity state when the RingHash picker is created and respond to some code review comments.
larry-safran
committed
Change disable to not do shutdown and then have acceptResolvedAddresses explicitly do the shutdowns after updating picker by default
larry-safran
committed
Add tests to make sure that removed addresses have their subchannels shutdown in acceptResolvedAddresses.
larry-safran
committed
Per code review, split the updating children from updating balancing state and removed child cleanup in acceptResolvedAddresses.
larry-safran
committed
Per code review, split the updating balancing state from the removed child cleanup when processing acceptResolvedAddresses.
larry-safran
committed
Address code review issues. Mostly simplifications. Changed to not try to start a connection in updateBalancingState when there aren't any active subchannels.
larry-safran
committed
Complete comment
larry-safran
committed
Complete comment
larry-safran
committed
Change rules for reporting overall state so that if nothing is ready and there are 2+ TF then report TF. 1 TF + idle/connecting report connecting.
larry-safran
committed
Address checkstyle violations
larry-safran
committed
Fix rebase problems
larry-safran
committed
android: Remove unneeded proguard rule

ejona86
authored and
larry-safran
committed
stub: Deprecate StreamObservers (#10654)

temawi
authored and
larry-safran
committed
Do nothing change to try to get builds to pull in later master
larry-safran
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Ring Hash LB a petiole policy#10610

Make Ring Hash LB a petiole policy#10610
larry-safran merged 26 commits intogrpc:masterfrom
larry-safran:ring_hash_dualstack

Commits on Nov 8, 2023

Change Round Robin and WeightedRoundRobin into petiole policies

Responded to a number of the code review comments.

suppress bogus warning.

Address code review comments improving reuse and avoiding creating children just to immediately delete them.

Checkpoint LeastRequestLoadBALANCERTEST

Complete LeastRequestLoadBalancer

revert changes to PickFirst that were made to expose status that is no longer needed

Commits on Nov 9, 2023

Checkpoint

Complete fixing implementation and tests so that all tests pass as expected.

Update picker logic per A61 that it no longer pays attention to the first 2 elements, but rather takes the first ring element not in TF and uses that.

Fix style issues.

Cleanup after rebasing.

Go back to caching the connectivity state when the RingHash picker is created and respond to some code review comments.

Change disable to not do shutdown and then have acceptResolvedAddresses explicitly do the shutdowns after updating picker by default

Add tests to make sure that removed addresses have their subchannels shutdown in acceptResolvedAddresses.

Per code review, split the updating children from updating balancing state and removed child cleanup in acceptResolvedAddresses.

Per code review, split the updating balancing state from the removed child cleanup when processing acceptResolvedAddresses.

Address code review issues. Mostly simplifications. Changed to not try to start a connection in updateBalancingState when there aren't any active subchannels.

Complete comment

Complete comment

Change rules for reporting overall state so that if nothing is ready and there are 2+ TF then report TF. 1 TF + idle/connecting report connecting.

Address checkstyle violations

Fix rebase problems

android: Remove unneeded proguard rule

stub: Deprecate StreamObservers (#10654)

Do nothing change to try to get builds to pull in later master