Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example dependencies #19

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Update example dependencies #19

merged 1 commit into from
Dec 14, 2018

Conversation

jyane
Copy link
Member

@jyane jyane commented Dec 14, 2018

  1. Update gradle to 4.9
    Same as grpc-java, see also: grpc/grpc-java@94b2618

  2. Update error-prone to 2.3.2

  3. Update grpc to 1.17.1
    Add a grpc project name prefix to io_grpc_grpc_java

@jyane
Update example dependencies
993b9d6 
1. Update gradle to 4.9
  - Same as grpc-java, see also: grpc/grpc-java@94b2618

2. Update error-prone to 2.3.2

3. Update grpc to 1.17.1
  - Add a grpc project name prefix to `io_grpc_grpc_java`
@jyane jyane requested a review from ericgribkoff December 14, 2018 04:49
@jyane
Copy link
Member Author

jyane commented Dec 14, 2018

Would you take this PR? @ericgribkoff

ericgribkoff
ericgribkoff approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@ericgribkoff ericgribkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@ericgribkoff ericgribkoff merged commit c754153 into grpc:master Dec 14, 2018
@jyane jyane deleted the update-example-deps branch December 15, 2018 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericgribkoff ericgribkoff ericgribkoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyane @ericgribkoff