Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start 1.2.0 development cycle #16

Merged
merged 3 commits into from
Mar 29, 2018

Conversation

ericgribkoff
Copy link
Contributor

v1.1.0 is tagged and pushed to Maven.

@jyane
Copy link
Member

jyane commented Mar 29, 2018

1.1.0 is already available on maven central, I've checked sync was done.
Updating examples will be follow up?

@jyane jyane self-requested a review March 29, 2018 03:56
jyane
jyane previously approved these changes Mar 29, 2018
@ericgribkoff
Copy link
Contributor Author

Examples bumped to 1.1.0 now too

@@ -12,6 +12,6 @@ grpc_java_repositories()

maven_jar(
name = "io_grpc_grpc_java_api_checker",
artifact = "io.grpc:grpc-java-api-checker:1.0.0",
artifact = "io.grpc:grpc-java-api-checker:1.1.0",
sha1 = "68fe2fc82e1f673b042fb7192a3724d1464d0582",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it d0c4b2979fbd7127d0c3e587f9076ead9457d344 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jyane jyane dismissed their stale review March 29, 2018 17:56

dismiss due to incorrect sha.

Copy link
Member

@jyane jyane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@ericgribkoff ericgribkoff merged commit cf3231b into grpc:master Mar 29, 2018
@ericgribkoff ericgribkoff deleted the start_1.2_iteration branch March 29, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants