-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a bazel example #12
Conversation
Fixes grpc#2
java_plugin( | ||
name = "io_grpc_grpc_java_api_checker_plugin", | ||
deps = [ | ||
"@com_google_guava_guava//jar", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think about guava version since this PR, but should we use guava:19.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah... This tool does not require the guava (It is an optional dependency), so the user could use any guava version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve noticed that some dependencies in pom may not be needed, I’ll dig into it.
Can you add instructions for building with bazel to the readme too? Just doing |
Thanks!
Nope, It works on my local machine, doesn't work on your local machine? If it doesn't work, it means we should add some tests.
edit: More information on my local machine
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The bazel example build works fine, it was just an error on my part earlier
Thank you for your review! Merging. |
Fixes #2