Skip to content

internal/balancer/clusterimpl: replace testpb with testgrpc #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

internal/balancer/clusterimpl: replace testpb with testgrpc #8188

merged 1 commit into from
Mar 21, 2025

Conversation

@eshitachandwani
Copy link
Member

RELEASE NOTES: N/A

@eshitachandwani eshitachandwani added Type: Internal Cleanup Refactors, etc Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. labels Mar 21, 2025
@eshitachandwani eshitachandwani added this to the 1.72 Release milestone Mar 21, 2025
@codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.95%. Comparing base (d8924ac) to head (32eea25).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8188      +/-   ##
==========================================
- Coverage   81.99%   81.95%   -0.05%     
==========================================
  Files         410      410              
  Lines       40237    40237              
==========================================
- Hits        32993    32975      -18     
- Misses       5873     5886      +13     
- Partials     1371     1376       +5

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

purnesh42H
purnesh42H approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eshitachandwani eshitachandwani merged commit 43a4a84 into grpc:master Mar 21, 2025
15 checks passed
@eshitachandwani eshitachandwani deleted the imprt_fix branch March 21, 2025 11:52
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Mar 24, 2025
@eshitachandwani @janardhankrishna-sai
internal/balancer/clusterimpl: replace testpb with testgrpc (grpc#8188)
399adf7
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@purnesh42H purnesh42H purnesh42H approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eshitachandwani eshitachandwani

Labels

Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Internal Cleanup Refactors, etc

Projects

None yet

Milestone

1.72 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@eshitachandwani @purnesh42H