Skip to content

interop: Introduce env var for xDS dualstack support and add xDS interop config #8081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

arjan-bal
Copy link
Contributor

Fixes: #7866

Why

This PR is required to start PSM interop testing for dualstack integration in Go. The interop test only tests the roundrobin LB policy which is already updated to handle endpoints in #7966.

Testing

Verified that the dualstack PSM interop tests pass when run using a client image built from this branch.

RELEASE NOTES:

  • xds: LB policies will receive additional addresses for endpoints which are specified in the additional_addresses field in the Endpoint message. The additional addresses will be present in the ResolverState.Endpoints passed to UpdateClientConnState method of the balancers. To enable this feature, set the environment variable GRPC_EXPERIMENTAL_XDS_DUALSTACK_ENDPOINTS to true (case insensitive).

@arjan-bal arjan-bal added Type: Testing Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. labels Feb 12, 2025
@arjan-bal arjan-bal added this to the 1.71 Release milestone Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.31%. Comparing base (ad5cd32) to head (ef3d236).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8081      +/-   ##
==========================================
+ Coverage   82.10%   82.31%   +0.21%     
==========================================
  Files         387      387              
  Lines       39067    39064       -3     
==========================================
+ Hits        32076    32157      +81     
+ Misses       5662     5596      -66     
+ Partials     1329     1311      -18     

see 26 files with indirect coverage changes

@arjan-bal arjan-bal requested review from easwars and dfawley February 12, 2025 12:54
@arjan-bal arjan-bal changed the title interop: Introduce env var for xDS dualstack and add xDS interop config interop: Introduce env var for xDS dualstack support and add xDS interop config Feb 12, 2025
@easwars easwars assigned arjan-bal and unassigned easwars and dfawley Feb 12, 2025
@arjan-bal arjan-bal merged commit 75c51bf into grpc:master Feb 13, 2025
15 checks passed
@arjan-bal arjan-bal deleted the enable-dualstack-test branch February 13, 2025 04:29
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Feb 15, 2025
@arjan-bal arjan-bal added Type: Feature New features or improvements in behavior and removed Type: Testing labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xds: Expose Dualstack support using an environment variable
3 participants