test: modify tests to use stubserver instead of test service #7976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7976 +/- ##
==========================================
- Coverage 82.05% 82.04% -0.01%
==========================================
Files 381 381
Lines 38539 38539
==========================================
- Hits 31622 31620 -2
+ Misses 5602 5598 -4
- Partials 1315 1321 +6 |
purnesh42H
reviewed
Jan 3, 2025
test/healthcheck_test.go
Outdated
| } | ||
| healthgrpc.RegisterHealthServer(stub.S, ts) | ||
| stubserver.StartTestService(t, stub) | ||
| t.Cleanup(func() { stub.Stop() }) |
test/stats_test.go
Outdated
| errCh := make(chan error) | ||
| go func() { | ||
| errCh <- s.Serve(l) | ||
| errCh <- ss.S.Serve(ss.Listener) |
There was a problem hiding this comment.
we should remove the redundant Serve since StartTestService already start the server. This has to be followed for every change. Please keep in mind for future changes.
purnesh42H
requested changes
Jan 6, 2025
test/healthcheck_test.go
Outdated
| return s, lis, ts | ||
| stub := &stubserver.StubServer{ | ||
| Listener: lis, | ||
| EmptyCallF: func(_ context.Context, _ *testpb.Empty) (*testpb.Empty, error) { |
There was a problem hiding this comment.
From where did this EmptyCallF and FullDuplexCallF implementation taken from? How is this being used? I can't find it. The testServer{} which is being replaced has totally different implementation here
Line 150 in 724f450
| @@ -255,6 +246,5 @@ func (s) TestConnsCleanup(t *testing.T) { | |||
| t.Fatalf("timeout waiting for lis wrapper conns to clear, size: %v", lenConns) | |||
| } | |||
|
|
|||
| server.Stop() | |||
| wg.Wait() | |||
| ss.S.Stop() | |||
There was a problem hiding this comment.
this should be done right after stubserver.StartTestService() as defer statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Addresses: #7291
RELEASE NOTES: None