Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: replace dial with newclient #7975

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

cleanup: replace dial with newclient #7975

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7d2a53b
replace dial with newclient
janardhankrishna-sai Dec 31, 2024
66a6a32
passing passthrough to the newclient and updating err msg
janardhankrishna-sai Dec 31, 2024
614299d
adding close() for goroutine leak and using fatal instead of log
janardhankrishna-sai Dec 31, 2024
beb8b0f
waiting for the test balancer to be built before getting the state no…
janardhankrishna-sai Dec 31, 2024
b405e43
replace dial with newclient and updating error msg
janardhankrishna-sai Dec 31, 2024
1748c69
reverting config whitespaces
janardhankrishna-sai Dec 31, 2024
be8a69f
reverting config whitespaces
janardhankrishna-sai Dec 31, 2024
fe19ecf
updating error msg
janardhankrishna-sai Dec 31, 2024
77953ec
updating error msg
janardhankrishna-sai Jan 1, 2025
3e1fc48
addressing review comments
janardhankrishna-sai Jan 2, 2025
09b067c
using r.InitialState instead of r.UpdateState
janardhankrishna-sai Jan 2, 2025
1fddf6b
defining load balancing grpclb service config
janardhankrishna-sai Jan 3, 2025
6f1e7c2
using load balancing service config
janardhankrishna-sai Jan 3, 2025
ab5f146
using internal.ParseServiceConfig to avoid depending on manual resolv…
janardhankrishna-sai Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updating error msg
  • Loading branch information
@janardhankrishna-sai
janardhankrishna-sai committed Jan 1, 2025
commit 77953ecf7c1a33c94b785b4dbb7d913c07686476
6 changes: 3 additions & 3 deletions test/end2end_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3006,7 +3006,7 @@ func (s) TestTransparentRetry(t *testing.T) {
server.start(t, lis)
cc, err := grpc.NewClient(lis.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()))
if err != nil {
t.Fatalf("failed to create a client: %v", err)
t.Fatalf("failed to create a client for the server: %v", err)
}
defer cc.Close()

Expand Down Expand Up @@ -5072,7 +5072,7 @@ func (s) TestServeExitsWhenListenerClosed(t *testing.T) {

cc, err := grpc.NewClient(lis.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()))
if err != nil {
t.Fatalf("Failed to create a client to the server: %v", err)
t.Fatalf("Failed to create a client for server: %v", err)
}
defer cc.Close()
c := testgrpc.NewTestServiceClient(cc)
Expand Down Expand Up @@ -5246,7 +5246,7 @@ func (s) TestDisabledIOBuffers(t *testing.T) {
defer s.Stop()
cc, err := grpc.NewClient(lis.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithWriteBufferSize(0), grpc.WithReadBufferSize(0))
if err != nil {
t.Fatalf("Failed to create a client to server")
t.Fatalf("Failed to create a client for server")
}
defer cc.Close()
c := testgrpc.NewTestServiceClient(cc)
Expand Down
Loading