-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: fix message length checks when compression is enabled and maxReceiveMessageSize is MaxInt #7918
Merged
dfawley
merged 35 commits into
grpc:master
from
vinothkumarr227:4552-max-receive-message-size-decompression
Jan 23, 2025
Merged
grpc: fix message length checks when compression is enabled and maxReceiveMessageSize is MaxInt #7918
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
b08845a
Fix test cases and update code to latest branch
vinothkumarr227 a02e58c
small tweaks
vinothkumarr227 54da70d
small tweaks
vinothkumarr227 4efd6fe
update code based on review feedback
vinothkumarr227 851d13a
fixed the changes based on review feedback
vinothkumarr227 26bf731
Added test cases for Handles maxReceiveMessageSize as MaxInt64
vinothkumarr227 3cf9054
Fixed the review changes
vinothkumarr227 27a68a0
Remove the casting for doesReceiveMessageOverflow
vinothkumarr227 3daef9b
Resolve all the issues
vinothkumarr227 8815cbd
Refactored code changes done
vinothkumarr227 5541486
test: switching to stubserver in tests instead of testservice (#7925)
pvsravani a21e192
cleanup: replace dial with newclient (#7920)
janardhanvissa 09132bf
deps: update crypto dependency to resolve CVE-2024-45337 (#7956)
TomerJLevy 5181e7b
test: Workaround slow SRV lookups in flaking test (#7957)
arjan-bal 46faf72
envconfig: enable xDS client fallback by default (#7949)
easwars bd4989a
test: Add a test for decompression exceeding max receive message size…
arjan-bal 985965a
outlierdetection: Support health listener for ejection updates (#7908)
arjan-bal 8a0db4c
Revert "test: switching to stubserver in tests instead of testservice…
vinothkumarr227 cf12ace
Revert "cleanup: replace dial with newclient (#7920)"
vinothkumarr227 0e927fb
Revert "deps: update crypto dependency to resolve CVE-2024-45337 (#79…
vinothkumarr227 ee88fc0
Revert "envconfig: enable xDS client fallback by default (#7949)"
vinothkumarr227 4ef6aab
Revert "test: Add a test for decompression exceeding max receive mess…
vinothkumarr227 7ef57fd
Revert "outlierdetection: Support health listener for ejection update…
vinothkumarr227 20d4dc6
Revert the changes
vinothkumarr227 0907f9d
Revert the changes for test cases
vinothkumarr227 84e8a4f
Fix decompression size check and refactor based on review feedback
vinothkumarr227 77ea230
small tweaks
vinothkumarr227 6ff9321
Fixed the space formatting issues
vinothkumarr227 82124a4
Rename the test cases and refactor some of them
vinothkumarr227 4e9c665
Fix reviewed changes
vinothkumarr227 da82d30
small tweaks
vinothkumarr227 33962c2
Fixed test cases for decompress function
vinothkumarr227 23baa53
Fixed test cases for dock block
vinothkumarr227 7664e75
small tweaks
vinothkumarr227 6fb580c
Fixed review changes for the decompress function
vinothkumarr227 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
small tweaks
- Loading branch information
commit da82d307535222a9c374a7e13a847654364f1e15
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this an error scenario? If the payload is compressed (which is the only reason to call this function) and we don't have the decompressor, then we should error.
In reality, this can't happen because
checkRecvPayload
would prevent it, but this should still return an error, not a success.