Skip to content

cleanup: use SliceBuffer directly where no pool is available #7827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

ash2k
Copy link
Contributor

@ash2k ash2k commented Nov 12, 2024

As discussed in #7653 (comment), this is a minor code simplification.

RELEASE NOTES: none

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.91%. Comparing base (60c70a4) to head (c5dc2b1).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
codec.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7827      +/-   ##
==========================================
- Coverage   81.93%   81.91%   -0.02%     
==========================================
  Files         373      373              
  Lines       37880    37880              
==========================================
- Hits        31036    31031       -5     
- Misses       5550     5559       +9     
+ Partials     1294     1290       -4     
Files with missing lines Coverage Δ
preloader.go 58.33% <100.00%> (ø)
rpc_util.go 79.48% <100.00%> (ø)
codec.go 9.09% <0.00%> (ø)

... and 17 files with indirect coverage changes

---- 🚨 Try these New Features:

@arjan-bal arjan-bal added this to the 1.69 Release milestone Nov 12, 2024
@arjan-bal arjan-bal added the Type: Internal Cleanup Refactors, etc label Nov 12, 2024
@arjan-bal arjan-bal requested a review from easwars November 12, 2024 05:51
@easwars easwars assigned dfawley and unassigned easwars Nov 18, 2024
@easwars
Copy link
Contributor

easwars commented Nov 18, 2024

Moving to @dfawley for second set of eyes.

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dfawley dfawley merged commit ee3fb29 into grpc:master Nov 18, 2024
15 checks passed
@ash2k ash2k deleted the ash2k/use-SliceBuffer-directly branch November 19, 2024 00:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants