Revert "protoc-gen-go-grpc: remove use_generic_streams_experimental flag (defaults to true) (#7654)
#7703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7703 +/- ##
==========================================
+ Coverage 81.84% 81.86% +0.01%
==========================================
Files 361 361
Lines 27822 27822
==========================================
+ Hits 22772 22776 +4
+ Misses 3854 3851 -3
+ Partials 1196 1195 -1 |
dfawley
approved these changes
Oct 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #7654 which attempted to:
This revert is necessary because the previous changes caused compatibility issues with existing usages of client and server stream methods within internal google3.
We will revisit this change once the affected usages in google3 have been migrated.
RELEASE NOTES: None