Skip to content

cherry-pick #7660 to v1.66.x branch #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Sep 24, 2024

Fixes: #7641
Original PR: #7660

RELEASE NOTES:

  • transport: Fix a bug causing stream failures due to miscalculation of the flow control window in both clients and servers.

@arjan-bal arjan-bal added Type: Bug Area: Transport Includes HTTP/2 client/server and HTTP server handler transports and advanced transport features. labels Sep 24, 2024
@arjan-bal arjan-bal added this to the 1.66 Release milestone Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (a75eb1e) to head (d53bc9a).
Report is 1 commits behind head on v1.66.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.66.x    #7668      +/-   ##
===========================================
- Coverage    81.90%   81.78%   -0.12%     
===========================================
  Files          361      361              
  Lines        27858    27858              
===========================================
- Hits         22816    22783      -33     
- Misses        3851     3868      +17     
- Partials      1191     1207      +16     
Files with missing lines Coverage Δ
internal/transport/transport.go 92.69% <100.00%> (+1.53%) ⬆️

... and 21 files with indirect coverage changes

@easwars
Copy link
Contributor

easwars commented Sep 25, 2024

@dfawley : Do we want to cherrypick this into 1.66? We already have 1.67 out and we are cherrypicking this into 1.67. There is about a month to go for 1.68 though.

The reason I'm asking is if somebody is bitten by this bug in 1.66, what is the value of having another patch release in 1.66 to upgrade to over upgrading to 1.67.

@dfawley
Copy link
Member

dfawley commented Sep 25, 2024

Yes, we should do a patch release of 1.66 with this, too, since it's a pretty serious issue..

@arjan-bal arjan-bal assigned arjan-bal and unassigned purnesh42H Sep 25, 2024
@arjan-bal arjan-bal merged commit bcbf356 into grpc:v1.66.x Sep 25, 2024
13 of 14 checks passed
@arjan-bal arjan-bal deleted the cherrypick/7660-fix-flow-control branch September 25, 2024 16:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Transport Includes HTTP/2 client/server and HTTP server handler transports and advanced transport features. Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants