Skip to content

stats/opentelemetry: Add RLS Metrics e2e tests #7655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Sep 20, 2024

This PR adds e2e tests for RLS Metrics, with verifications of the OpenTelemetry metrics atoms emitted.

RELEASE NOTES:

  • stats/opentelemetry: De-experimentalize OpenTelemetry instrumentation component and CSM Observability

@zasweq zasweq requested a review from easwars September 20, 2024 20:55
@zasweq zasweq added this to the 1.68 Release milestone Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (31ffeee) to head (832a2c6).
Report is 47 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7655      +/-   ##
==========================================
+ Coverage   81.73%   82.30%   +0.57%     
==========================================
  Files         361      367       +6     
  Lines       27817    28934    +1117     
==========================================
+ Hits        22735    23814    +1079     
- Misses       3871     3884      +13     
- Partials     1211     1236      +25     

see 47 files with indirect coverage changes

@zasweq zasweq force-pushed the rls-metrics-e2e-tests branch from c56189c to e055c38 Compare September 20, 2024 21:00
@easwars
Copy link
Contributor

easwars commented Sep 23, 2024

@zasweq : I'm not going to be able to get to this for at least a week. Please find another reviewer if you want it reviewed sooner. Thanks.

@easwars easwars assigned zasweq and unassigned easwars Sep 23, 2024
@zasweq zasweq requested a review from dfawley September 23, 2024 16:17
@zasweq zasweq assigned dfawley and unassigned zasweq Sep 23, 2024
@zasweq zasweq removed the request for review from easwars September 23, 2024 16:17
@dfawley
Copy link
Member

dfawley commented Sep 30, 2024

As discussed offline: RLS's tests should go with RLS, not with OTel, and this PR is about testing RLS not OTel.

That also prevents the need to fork a copy of / move the testing helper code around.

@dfawley dfawley assigned zasweq and unassigned dfawley Sep 30, 2024
@zasweq
Copy link
Contributor Author

zasweq commented Oct 1, 2024

Moved to balancer/rls. Thanks.

@zasweq zasweq assigned dfawley and unassigned zasweq Oct 1, 2024
@dfawley dfawley assigned zasweq and unassigned dfawley Oct 1, 2024
@zasweq zasweq force-pushed the rls-metrics-e2e-tests branch from b6790b5 to c51df56 Compare October 1, 2024 21:56
@zasweq zasweq force-pushed the rls-metrics-e2e-tests branch from d024e73 to 832a2c6 Compare October 1, 2024 23:07
@zasweq zasweq assigned dfawley and unassigned zasweq Oct 1, 2024
@zasweq
Copy link
Contributor Author

zasweq commented Oct 1, 2024

Fixed the go.mods due to moving it by deleting the stats/opentelemetry go.mod.

@purnesh42H purnesh42H modified the milestones: 1.68 Release, 1.69 Release Oct 16, 2024
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes us release the opentelemetry package and also CSM. We should make sure the release notes mention that. And make sure all the APIs contained in both are either marked as experimental or are believed to be stable.

@zasweq
Copy link
Contributor Author

zasweq commented Oct 18, 2024

Due to merge conflicts from updating repository dependencies opened #7759.

@zasweq zasweq closed this Oct 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants