Skip to content

examples/retry: remove waitForReady from service config #7450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jul 29, 2024

This setting is irrelevant, so remove it to avoid any confusion.

Fixes #7440

RELEASE NOTES: none

@dfawley dfawley added the Type: Documentation Documentation or examples label Jul 29, 2024
@dfawley dfawley added this to the 1.66 Release milestone Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.30%. Comparing base (0231b0d) to head (e164dd5).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7450      +/-   ##
==========================================
- Coverage   81.44%   81.30%   -0.14%     
==========================================
  Files         352      354       +2     
  Lines       26919    27076     +157     
==========================================
+ Hits        21924    22014      +90     
- Misses       3804     3844      +40     
- Partials     1191     1218      +27     
Files Coverage Δ
rpc_util.go 81.63% <ø> (ø)

... and 35 files with indirect coverage changes

@purnesh42H
Copy link
Contributor

purnesh42H commented Jul 29, 2024

We should update in these two places as well

Also, might be good to put a note in documentation that this setting is not relevant for retry policies

@dfawley
Copy link
Member Author

dfawley commented Jul 29, 2024

IIRC, in the tests, WFR is used as a trick to detect that the service config was properly applied by the client. I'll update the corresponding doc for the example and look at the WFR docstring.

@dfawley
Copy link
Member Author

dfawley commented Jul 29, 2024

PTAL

@purnesh42H purnesh42H self-requested a review July 29, 2024 18:03
Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dfawley dfawley merged commit 566aad1 into grpc:master Jul 29, 2024
13 checks passed
@dfawley dfawley deleted the retry-no-wfr branch July 29, 2024 18:06
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 30, 2024
@dfawley dfawley restored the retry-no-wfr branch October 14, 2024 18:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is waitForReady required for retry policies?
3 participants