-
Notifications
You must be signed in to change notification settings - Fork 4.5k
examples/retry: remove waitForReady from service config #7450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7450 +/- ##
==========================================
- Coverage 81.44% 81.30% -0.14%
==========================================
Files 352 354 +2
Lines 26919 27076 +157
==========================================
+ Hits 21924 22014 +90
- Misses 3804 3844 +40
- Partials 1191 1218 +27
|
We should update in these two places as well
Also, might be good to put a note in documentation that this setting is not relevant for retry policies |
IIRC, in the tests, WFR is used as a trick to detect that the service config was properly applied by the client. I'll update the corresponding doc for the example and look at the WFR docstring. |
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This setting is irrelevant, so remove it to avoid any confusion.
Fixes #7440
RELEASE NOTES: none