.github: Skip OpenTelemetry module in go 1.20 tests #7246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
force-pushed
the
ignore-opentelemetry-1.20
branch
2 times, most recently
from
695634b to
fe62af2
Compare
zasweq
force-pushed
the
ignore-opentelemetry-1.20
branch
from
fe62af2 to
0ee4b76
Compare
dfawley
reviewed
May 20, 2024
| @@ -105,7 +105,10 @@ jobs: | |||
| cd "${GITHUB_WORKSPACE}" | |||
| for MOD_FILE in $(find . -name 'go.mod' | grep -Ev '^\./go\.mod'); do | |||
| pushd "$(dirname ${MOD_FILE})" | |||
| go test ${{ matrix.testflags }} -cpu 1,4 -timeout 2m ./... | |||
| # Skip OpenTelemetry module if go 1.20, Go OpenTelemetry does not support 1.20. | |||
| if [[ matrix.goversion != 1.20 ]] || [[ dirname != ./stats/opentelemetry* ]]; then | |||
There was a problem hiding this comment.
Also, can we do something clever here to ensure the condition is met once?
Meaning when we drop support for go1.20, I want to make sure we know to delete this. We can do that by (pseudo-code):
for MOD_FILE:
if goversion == 1.20 && dirname == otel:
skipped = true
else:
go test
if !skipped:
fail
There was a problem hiding this comment.
Oh I don't know why I added *, for some reason I wanted starts with even though this is only one module. I'm going to move this inline with changes in other PR, good point. Ok will add that.
|
Closing this PR, decided to inline in #7205. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: N/A