Skip to content

security/advancedtls: CRL checks improvement #6968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Conversation

erm-g
Copy link
Contributor

@erm-g erm-g commented Feb 7, 2024

Part of CRL Provider effort. The functionality in this PR includes enhancements for verifyCRL function to get it aligned with RFC 5280

RELEASE NOTES: N/A

@erm-g erm-g requested a review from gtcooke94 February 7, 2024 02:17
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #6968 (68571ff) into master (6ce73bf) will decrease coverage by 1.44%.
Report is 27 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6968      +/-   ##
==========================================
- Coverage   83.76%   82.33%   -1.44%     
==========================================
  Files         287      296       +9     
  Lines       30835    31450     +615     
==========================================
+ Hits        25829    25893      +64     
- Misses       3951     4497     +546     
- Partials     1055     1060       +5     

see 55 files with indirect coverage changes

@ginayeh ginayeh added this to the 1.62 Release milestone Feb 8, 2024
@ginayeh ginayeh added the Type: Security A bug or other problem affecting security label Feb 8, 2024
@ginayeh ginayeh modified the milestones: 1.62 Release, 1.63 Release Feb 8, 2024
@erm-g erm-g requested a review from gtcooke94 February 12, 2024 00:24
@erm-g erm-g requested a review from gtcooke94 February 14, 2024 13:27
Copy link
Contributor

@gtcooke94 gtcooke94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erm-g erm-g requested a review from dfawley February 14, 2024 17:54
@dfawley dfawley assigned dfawley and unassigned gtcooke94 Feb 14, 2024
@dfawley dfawley merged commit 408139a into grpc:master Feb 14, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Security A bug or other problem affecting security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants