fix 'identitiy' typo in error message #6909
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to fix the typo here as well xds/internal/xdsclient/xdsresource/listener_resource_type.go |
|
Should be ready for review now |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6909 +/- ##
==========================================
+ Coverage 83.73% 83.80% +0.06%
==========================================
Files 287 287
Lines 30829 30829
==========================================
+ Hits 25816 25836 +20
+ Misses 3958 3942 -16
+ Partials 1055 1051 -4
|
arvindbr8
suggested changes
Jan 8, 2024
| @@ -430,7 +430,7 @@ type ClientHeader struct { | |||
| MethodName string `protobuf:"bytes,2,opt,name=method_name,json=methodName,proto3" json:"method_name,omitempty"` | |||
| // A single process may be used to run multiple virtual | |||
| // servers with different identities. | |||
| // The authority is the name of such a server identitiy. | |||
| // The authority is the name of such a server identity. | |||
There was a problem hiding this comment.
We should not be modifying this pb.go as this is generated from protos in the grpc-proto repo. And this comment comes from here.
Let us rollback the changes to this file and cut a PR to fix the typo in the proto definition in the gRPC-proto repo. This will fix it the next time we generate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: none