server: fix semaphore release #6737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The acquire and release functions should have opposite impacts on the count. Credit to @colega who spotted the diff. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
3 tasks
colega
added a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2023
This includes fix from grpc/grpc-go#6737 Should fix #6385 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2023
* Update grpc to 1.57.2-dev This includes fix from grpc/grpc-go#6737 Should fix #6385 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> --------- Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
dfawley
approved these changes
Oct 18, 2023
Member
dfawley
left a comment
dfawley
left a comment
There was a problem hiding this comment.
👀 Not sure how this happened, sorry!
Contributor
Author
|
I looked at the CI failure; can’t see how it can be related to this PR. |
Member
It isn't related, and it's an optional checker so won't block merging. However, we do require 2 maintainers to review PRs before merging, which is why I haven't merged it yet. |
ginayeh
approved these changes
Oct 18, 2023
smira
added a commit
to smira/talos
that referenced
this pull request
Oct 19, 2023
See grpc/grpc-go#6737 Note: this isn't a problem in `main`, as we're using 1.58 there, and it never had this bug. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a bug in v1.57.1 where servers will run very sluggishly, and also take ages to shut down.
The acquire and release functions should have opposite impacts on the count.
Credit to @colega who spotted the diff.
This was introduced in #6706, a backport of #6703, where the line is correct.
https://github.com/grpc/grpc-go/pull/6703/files#diff-366e46a40f6f60b4f7614eb0976bb51820364bf5ca6ccc4787eb49d7bdbef3e6R2098
Also correct in the 1.56 backport: https://github.com/grpc/grpc-go/pull/6708/files#diff-366e46a40f6f60b4f7614eb0976bb51820364bf5ca6ccc4787eb49d7bdbef3e6R2073
RELEASE NOTES: n/a