Add LocalAddr to peer.Peer (#6577) #6702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files |
zasweq
suggested changes
Oct 17, 2023
Comment on lines
+2386
to
+2389
| pla := peer.LocalAddr.String() | ||
| if _, _, err := net.SplitHostPort(pla); err != nil { | ||
| t.Fatalf("Failed to parse local address from peer.") | ||
| } |
There was a problem hiding this comment.
Can you please assert the actual local addr here? rather than just checking it split host port. Same in other test. (Listener, Conn or hardcoded)
| @@ -161,14 +161,18 @@ func checkRoundRobinRPCs(ctx context.Context, client testgrpc.TestServiceClient, | |||
| gotAddrCount = make(map[string]int) | |||
| // Perform 3 iterations. | |||
| var iterations [][]string | |||
| var localIterations [][]string | |||
There was a problem hiding this comment.
Please revert this file. We don't need to add these assertions here.
|
Closing this because this is part of #6716. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6577 , requesting the ability to log the local address in addition to the remote address for server-side interceptors for debugging.
It isn't obvious to me if we want to also include the local address in the server handler, here . This would require parsing the information form the http request, likely using X-Forward-For .
There may be the necessity for a followup ticket to extend the binarylog package to include the local address in gRPC binary logging.
Hope this helps!