experimental: add package and move recv buffer pool APIs into it #6692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Oct 9, 2023
Added the recv buffer pool APIs to the experimental package. PTAL. Thanks. |
easwars
changed the title
dfawley
reviewed
Oct 11, 2023
dialoptions.go
Outdated
Comment on lines
712
to
714
| return newFuncDialOption(func(o *dialOptions) { | ||
| o.recvBufferPool = bufferPool | ||
| }) |
There was a problem hiding this comment.
return withRecvBufferPool(bufferPool)
dfawley
reviewed
Oct 11, 2023
experimental/experimental.go
Outdated
| * | ||
| */ | ||
|
|
||
| // Package experimental is a placeholder for experimental features that might |
There was a problem hiding this comment.
s/placeholder for/ collection of/
dfawley
approved these changes
Oct 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: none