gracefulswitch, stub: remove last UpdateSubConnState references #6533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
approved these changes
Aug 9, 2023
| opts.StateListener = func(state balancer.SubConnState) { vb.UpdateSubConnState(sc, state) } | ||
| opts.StateListener = func(state balancer.SubConnState) { | ||
| if vb.closed.HasFired() { | ||
| vb.t.Fatalf("UpdateSubConnState(%+v) was called after Close(), which breaks the balancer API", state) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateSubConnStateerror if called, and do that behavior directly in theStateListenersUpdateSubConnStatefield, which requires all tests that use it to useStateListeners now (all migrated before this PR; requires balancer/weightedtarget: stop forwarding UpdateSubConnState calls #6525, included here as a separate commit).RELEASE NOTES: none