benchmark: restore old buffer size values for published benchmarks #6516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5762, the default values used by our benchmarks was changed to be the same as the default gRPC values. However, I was unaware that we were publishing these benchmarks at http://grpc.io. That led to this regression 👍
This change restores the values that were in use before the change, which should lower CPU usage by using bigger buffers. It does this in the client and server used by the benchmark framework, but not for our local benchmarks that we occasionally run to evaluate the performance impact of changes.
RELEASE NOTES: none