Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: disable channel idleness by default #6328

Merged
merged 1 commit into from
May 30, 2023
Merged

client: disable channel idleness by default #6328

merged 1 commit into from
May 30, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented May 30, 2023 •
edited
Loading

RELEASE NOTES: none

@dfawley dfawley added the Type: Feature New features or improvements in behavior label May 30, 2023
@dfawley dfawley added this to the 1.56 Release milestone May 30, 2023
@dfawley dfawley requested a review from ginayeh May 30, 2023 23:18
@dfawley dfawley merged commit 3ea58ce into grpc:master May 30, 2023
1 check passed
@dfawley dfawley deleted the idle_disable_default branch May 30, 2023 23:34
@easwars
Copy link
Contributor

easwars commented Jun 22, 2023

@dfawley

We want this to be enabled by default in the directpath affinity case, don't we? Are you planning to have client libraries explicitly enable it?

Or can we enable it by default given that we have fixed the actual bug in #6331.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ginayeh ginayeh ginayeh approved these changes

Assignees

@ginayeh ginayeh

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.56 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@dfawley @easwars @ginayeh