Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/tools: update staticcheck version to latest #5806

Merged
merged 4 commits into from
Nov 18, 2022
Merged

test/tools: update staticcheck version to latest #5806

merged 4 commits into from
Nov 18, 2022

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 18, 2022

I disabled two checkers:

  1. double-imports: we do this often for the proto messages vs. services
  2. deprecated ioutil functions. I don't think we want to make these changes yet.

One other fix was needed to use time.Since() instead of time.Now().Sub().

RELEASE NOTES: none

@dfawley dfawley added the Type: Dependencies Updating/adding/removing dependencies label Nov 18, 2022
@dfawley dfawley added this to the 1.52 Release milestone Nov 18, 2022
@dfawley dfawley requested a review from easwars November 18, 2022 19:54
easwars
easwars reviewed Nov 18, 2022
View reviewed changes
vet.sh Show resolved Hide resolved
@easwars easwars assigned dfawley and unassigned easwars Nov 18, 2022
easwars
easwars approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfawley dfawley merged commit 3011eaf into grpc:master Nov 18, 2022
@dfawley dfawley deleted the gomod branch November 18, 2022 21:51
jronak pushed a commit to jronak/grpc-go that referenced this pull request Nov 21, 2022
@dfawley @jronak
test/tools: update staticcheck version to latest (grpc#5806)
1b30a5a
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars easwars approved these changes

Assignees

@dfawley dfawley

Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Milestone
1.52 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @easwars