xds: enable Outlier Detection by default #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
force-pushed
the
outlier-detection-default-true
branch
from
39ae0b2
to
3109845
Compare
zasweq
force-pushed
the
outlier-detection-default-true
branch
from
3109845
to
ea476a5
Compare
easwars
reviewed
Sep 29, 2022
| // "GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION" to "true". | ||
| XDSOutlierDetection = strings.EqualFold(os.Getenv(outlierDetectionSupportEnv), "true") | ||
| // enabled, which can be disabled by setting the environment variable | ||
| // "GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION" to "false". |
There was a problem hiding this comment.
Nit: We haven't done this in the past, but at some point we discussed this. We should add the release that we are enabling it from, and add a TODO saying at what release we should completely get rid of the env var. Without this, we will have an ever growing list of env vars here and sprinkled everywhere else in the code.
| func TestBuildPriorityConfig(t *testing.T) { | ||
| gotConfig, gotAddrs, _ := buildPriorityConfig([]priorityConfig{ |
There was a problem hiding this comment.
Should we retain this test and run it with the env var set to "false"?
There was a problem hiding this comment.
I'm fine with removing it given we would like to eliminate the env var entirely in a few weeks.
dfawley
changed the title
dfawley
approved these changes
Sep 30, 2022
| func TestBuildPriorityConfig(t *testing.T) { | ||
| gotConfig, gotAddrs, _ := buildPriorityConfig([]priorityConfig{ |
There was a problem hiding this comment.
I'm fine with removing it given we would like to eliminate the env var entirely in a few weeks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: