Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: change the log-level when a new ServerTransport cannot be created #5524

Merged
merged 1 commit into from
Jul 19, 2022
Merged

grpc: change the log-level when a new ServerTransport cannot be created #5524

merged 1 commit into from
Jul 19, 2022

Conversation

jpkrohling
Copy link
Contributor

@jpkrohling jpkrohling commented Jul 19, 2022 •
edited by dfawley
Loading

Fixes #5523

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

RELEASE NOTES:

  • server: reduce log level from Warning to Info for early connection establishment errors

@jpkrohling
Change the log-level when a new ServerTransport cannot be created
b63870b 
Fixes grpc#5523

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling marked this pull request as draft July 19, 2022 21:04
@jpkrohling jpkrohling marked this pull request as ready for review July 19, 2022 21:10
@jpkrohling
Copy link
Contributor Author

I confirmed this to fix the issue I'm seeing on the OpenTelemetry Collector (open-telemetry/opentelemetry-collector#4747)

@dfawley dfawley requested a review from easwars July 19, 2022 21:20
@dfawley dfawley added this to the 1.49 Release milestone Jul 19, 2022
@dfawley dfawley added the Type: Behavior Change Behavior changes not categorized as bugs label Jul 19, 2022
@easwars easwars changed the title Change the log-level when a new ServerTransport cannot be created grpc: change the log-level when a new ServerTransport cannot be created Jul 19, 2022
@easwars easwars merged commit 6dd40ad into grpc:master Jul 19, 2022
@moul-bot moul-bot mentioned this pull request Oct 7, 2022
Closed
@moul-bot moul-bot mentioned this pull request Oct 17, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@easwars easwars easwars approved these changes

Assignees

@easwars easwars

Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Milestone
1.49 Release
Development

Successfully merging this pull request may close these issues.

Change the log-level when a new ServerTransport cannot be created
3 participants
@jpkrohling @easwars @dfawley