-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: remove retry disable via environment variable #4922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just keep RBAC env var? We have other env vars older than RBAC. And RBAC adds a new requirement of the responses, which is more likely to break if the control plane isn't up-to-date (#4924) We want to remove |
The ones which are tested sufficiently should be removed, too. I hadn't been looking at the others, but it seems like client side security and possibly ring hash should also be removed?
We want to remove retry because we believe it is sufficiently tested. Having too many flags is not a good idea. They are intended to be short-term testing tools, primarily. |
Removed the removal of RBAC control. This just deletes the retry control now. |
RELEASE NOTES: