Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/protoc-gen-go-grpc: call interceptor even if handler is unset #3849

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 26, 2020

This ensures all service handlers are non-nil when the service is registered, such that they can be called safely (after an interceptor in the case of unary RPCs).

Fixes #3847

@dfawley dfawley merged commit d31b671 into grpc:master Aug 26, 2020
@dfawley dfawley deleted the unimpl_interceptors branch August 26, 2020 23:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interceptor not called when method not implemented in v1.32
2 participants