-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation comments in rpc_util.go #1691
Fix deprecation comments in rpc_util.go #1691
Conversation
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
9a23208
to
79bd542
Compare
This can't be done until gRPC itself stops using the deprecated functions. If you would like to make those changes as well, we can approve them; otherwise, we will wait until we have the cycles to do that. |
79bd542
to
6441a04
Compare
I've updated 2 of 3. I'll try and get the last one sometime soon. |
6441a04
to
56cd6fb
Compare
The build failure on go1.9 seems unrelated, but I'm not sure. I think this is ready for a review |
The build failure on 1.9 is the gofmt check failing -- can you rerun it please? This also needs a rebase to resolve the conflict in balancer_switching_test.go Thanks! |
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
a2d0c56
to
0a67b09
Compare
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Fixed the conflicts, build is green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for seeing this through!
The golang convention for deprecating functions is to use
Deprecated:
. Most deprecated functions in this repo follow the convention, however a few inrpc_util.go
useDeprecated;
(semicolon).This PR fixes the comment string so that staticcheck will correctly recognize the function as deprecated.