Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't add defer func if stats handler is nil #1214

Merged
merged 1 commit into from
May 2, 2017
Merged

don't add defer func if stats handler is nil #1214

merged 1 commit into from
May 2, 2017

Conversation

kirk91
Copy link

@kirk91 kirk91 commented May 2, 2017

No description provided.

menghanl
menghanl approved these changes May 2, 2017
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@menghanl menghanl merged commit 0914b46 into grpc:master May 2, 2017
@kirk91 kirk91 deleted the fix-stats-defer branch May 3, 2017 02:05
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirk91 @menghanl