Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport: add tests to verify that client/server sends RST_STREAM(NO_ERROR) if not half-closed when receiving trailers #835

Open
ejona86 opened this issue Aug 16, 2016 · 1 comment
Open

transport: add tests to verify that client/server sends RST_STREAM(NO_ERROR) if not half-closed when receiving trailers #835

ejona86 opened this issue Aug 16, 2016 · 1 comment
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. fixit P3 Type: Testing

Comments

@ejona86
Copy link
Member

ejona86 commented Aug 16, 2016

This is the client-side version of #834, to handle the case when intermediaries are in play. Note that the RST_STREAM can be elided if the server sent a RST_STREAM after the EOS=true. But the client can't assume the server will send such a RST_STREAM.

Java and C aren't doing this today, but there are issues for them: grpc/grpc-java/issues/2163 and grpc/grpc#7734.
@menghanl menghanl added the P2 label Jun 16, 2017
@dfawley dfawley added P3 and removed P2 labels Dec 14, 2017
@dfawley
Copy link
Member

dfawley commented Mar 28, 2019

We are doing this (and the server-side RST_STREAM) but I don't believe we have tests for it -- I know we don't have tests for server-side, at least.

@dfawley dfawley added the fixit label Jun 5, 2019
@canguler canguler self-assigned this Jun 5, 2019
@stale stale bot added the stale label Sep 6, 2019
@dfawley dfawley removed the stale label Sep 6, 2019
@grpc grpc deleted a comment from stale bot May 3, 2021
dfawley pushed a commit to dfawley/grpc-go that referenced this issue Sep 24, 2021
@chalin
Android > Kotlin: link to Kotlin/JVM tutorial (grpc#835)
6beb7b8 
Until there is an Android Kotlin basics tutorial, at least link to the JVM version.
@easwars easwars changed the title Verify whether client sends RST_STREAM(NO_ERROR) if not half-closed when receiving trailers transport: add tests to verify that client sends RST_STREAM(NO_ERROR) if not half-closed when receiving trailers Aug 30, 2024
@easwars easwars changed the title transport: add tests to verify that client sends RST_STREAM(NO_ERROR) if not half-closed when receiving trailers transport: add tests to verify that client/server sends RST_STREAM(NO_ERROR) if not half-closed when receiving trailers Aug 30, 2024
@purnesh42H purnesh42H added the Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. fixit P3 Type: Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@menghanl @ejona86 @canguler @purnesh42H @dfawley