Skip to content

Typo in generated code comment: "pancis" should be "panics" in Register<foo>Server #7828

Closed
@chrisclapham

Description

@chrisclapham

What version of gRPC are you using?

google.golang.org/grpc v1.67.1
protoc-gen-go-grpc 1.5.1

What version of Go are you using (go version)?

go version go1.23.1 windows/amd64

What operating system (Linux, Windows, …) and version?

Microsoft Windows [Version 10.0.26100.2033]

What did you do?

I noticed a typo in the generated Go code comments from protoc-gen-go-grpc.

To reproduce:

  1. Create a simple .proto file with a service definition:
syntax = "proto3";

package example;
option go_package = "/examplepb";

message EmptyMessage {}

service ExampleService {
  rpc Example (EmptyMessage) returns (EmptyMessage) {}
}
  1. Generate the Go code using protoc with protoc-gen-go-grpc
  2. Examine the generated *_grpc.pb.go file

What did you expect to see?

// If the following call panics, it indicates UnimplementedServicesServer was...

What did you see instead?

// If the following call pancis, it indicates UnimplementedServicesServer was...

This is a minor documentation issue that doesn't affect functionality, but should be fixed for clarity and correctness. Thanks team.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions