Skip to content

Improve regenerate.sh to use the correct proto compiler version #6583

Closed
@easwars

Description

@easwars

Currently the regenerate script installs protoc-gen-go and protoc-gen-go-grpc in a workdir, but uses the system installed protoc which means that running the regenerate.sh script could result in all generated files being changed with a diff which would look something like:

@@ -20,7 +20,7 @@
 // Code generated by protoc-gen-go. DO NOT EDIT.
 // versions:
 //     protoc-gen-go v1.31.0
-//     protoc        v4.22.0
+//     protoc        v3.21.2
 // source: grpc/lb/v1/load_balancer.proto

Metadata

Metadata

Assignees

Labels

P2Type: FeatureNew features or improvements in behavior

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions