Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/clusterimpl: need better e2e tests #6113

Open
easwars opened this issue Mar 10, 2023 · 0 comments
Open

xds/clusterimpl: need better e2e tests #6113

easwars opened this issue Mar 10, 2023 · 0 comments
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. P2 Type: Testing

Comments

@easwars
Copy link
Contributor

easwars commented Mar 10, 2023

Current tests were not able to find the issue fixed by this PR: #6112

This is because they directly call UpdateClientConnState and pass it parsed service config. The clusterimpl LB policy like so many others in our tree of LB policies don't function in isolation. They work in concert with other LB policies. Our functional tests should be e2e style tests instead which rely on getting configuration from the management server, and have that config pass through the whole system before reaching the SUT.

As many of the existing tests should be re-written as e2e style tests.
@purnesh42H purnesh42H added the Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. P2 Type: Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@easwars @purnesh42H @zasweq