Skip to content

Fix possible race in Keepalive test: KeepaliveClientClosesWithActiveStreams #6099

Open
@arvindbr8

Description

@arvindbr8

KeepaliveClientClosesWithActiveStreams test creates a server which does not respond to keepalive pings, and makes sure that the client closes the transport even when there is an active stream. However there is a possibility of a race here.

In the test we assign a large enough ClientParameters.Time. However this does not guarantee that a stream can be created successfully before the timeout hits. This is because with the NoPingServer we do not have a configurable way to switch between a ping/noping server.

This way we can verify that the "no ping server" actually respond to pings until you set a flag, at which point it stops responding and the timeout kicks in to close the transport.

Metadata

Metadata

Assignees

Labels

Area: TestingIncludes tests and testing utilities that we have for unit and e2e tests within our repo.P2Type: Testing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions